0.8 Branch Modernization#2500
Open
johnnyshields wants to merge 5 commits intorails-api:0-8-stablefrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Many legacy Rails apps, including my own, are still using AMS 0.8.x.
What?
This PR modernizes the
0-8-stablebranch.The PR does NOT include any behavior changes.
Specific changes:
required_ruby_version, so older Ruby users will NOT be upgraded.) 2.7 is already deep, deep EOL.frozen_string_literal: trueto every file, in preparation for a future Ruby release requiring it. There's also one place where a string is now explicitly declared as non-frozen.I'd appreciate if this can be reviewed, merged, and released as version 0.8.5.