Clean a bit top-level SolidQueue methods to manage dynamic tasks

Author: rosa

app/models/solid_queue/recurring_task.rb

@@ -36,6 +36,14 @@ def from_configuration(key, **options)
           static: options.fetch(:static, true)
       end
 
+      def create_dynamic_task(key, **options)
+        from_configuration(key, **options.reverse_merge(static: false)).save!
+      end
+
+      def delete_dynamic_task(key)
+        RecurringTask.dynamic.find_by!(key: key).destroy
+      end
+
       def create_or_update_all(tasks)
         if supports_insert_conflict_target?
           # PostgreSQL fails and aborts the current transaction when it hits a duplicate key conflict

lib/solid_queue.rb

@@ -44,11 +44,11 @@ module SolidQueue
   delegate :on_start, :on_stop, :on_exit, to: Supervisor
 
   def schedule_recurring_task(key, **options)
-    RecurringTask.from_configuration(key, **options, static: false).tap(&:save!)
+    RecurringTask.create_dynamic_task(key, **options)
   end
 
   def unschedule_recurring_task(key)
-    RecurringTask.dynamic.find_by!(key:).destroy
+    RecurringTask.delete_dynamic_task(key)
   end
 
   [ Dispatcher, Scheduler, Worker ].each do |process|