Skip to content

Disable required check for tree and skip check_at_least_one! if disable_required_check #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoelTowell wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

Disable required check for tree and skip check_at_least_one! if disable_required_check #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aef9cd6
Disable required check for tree and skip check_at_least_one! if disab…
JoelTowell May 30, 2026
7f3bf70
Update disable_required_check comment
JoelTowell May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/thor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,9 +474,9 @@ def stop_on_unknown_option #:nodoc:
@stop_on_unknown_option ||= []
end

# help command has the required check disabled by default.
# help and tree commands have the required check disabled by default.
def disable_required_check #:nodoc:
@disable_required_check ||= [:help]
@disable_required_check ||= [:help, :tree]
end

def print_exclusive_options(shell, command = nil) # :nodoc:
Expand Down
2 changes: 1 addition & 1 deletion lib/thor/parser/options.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def parse(args) # rubocop:disable Metrics/MethodLength

check_requirement! unless @disable_required_check
check_exclusive!
check_at_least_one!
check_at_least_one! unless @disable_required_check

assigns = Thor::CoreExt::HashWithIndifferentAccess.new(@assigns)
assigns.freeze
Expand Down