fix(ci): use OIDC provenance for npm publish#826
Merged
Conversation
NODE_AUTH_TOKEN was explicitly set to empty string, which overrode the auth configured by setup-node and caused ENEEDAUTH failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove NODE_AUTH_TOKEN override (empty string broke auth) and add --provenance flag so npm exchanges the OIDC token automatically. id-token: write permission is already set on the job. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Publish to npmstep was settingNODE_AUTH_TOKEN="", which explicitly cleared the auth token thatactions/setup-nodeconfigures whenregistry-urlis provided. This causedENEEDAUTHfailures even though the job already hadid-token: writefor OIDC publishing.Fix
Removed the
NODE_AUTH_TOKENoverride and added--provenance --access publicto both the publish and dry-run steps. With--provenance, npm automatically exchanges the GitHub Actions OIDC token for a short-lived registry token - no secret needed.