Skip to content

Commit c4072dd

Browse files
Copilotrajbos
andcommitted
Address code review: fix step numbering in checklist, capture generate-notes API errors
Co-authored-by: rajbos <6085745+rajbos@users.noreply.github.com>
1 parent 24e9592 commit c4072dd

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

.github/workflows/release.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,11 +144,14 @@ jobs:
144144
# Use GitHub API to auto-generate notes from merged PRs since last release
145145
if gh api repos/${{ github.repository }}/releases/generate-notes \
146146
-f tag_name="${TAG_NAME}" \
147-
--jq '.body' > /tmp/release_notes.md 2>/dev/null && [ -s /tmp/release_notes.md ]; then
147+
--jq '.body' > /tmp/release_notes.md 2>/tmp/generate_notes_err.txt && [ -s /tmp/release_notes.md ]; then
148148
echo "✅ Generated release notes from merged PRs"
149149
else
150150
echo "Release ${VERSION}" > /tmp/release_notes.md
151151
echo "⚠️ Could not auto-generate notes, using fallback"
152+
if [ -s /tmp/generate_notes_err.txt ]; then
153+
echo " Error: $(cat /tmp/generate_notes_err.txt)"
154+
fi
152155
fi
153156
154157
echo "--- Release notes preview ---"

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ All builds must pass these checks before merging.
394394

395395
## Pre-Release Checklist
396396

397-
Run `npm run pre-release` to automate steps 1–2 below.
397+
Run `npm run pre-release` to validate the version and compile.
398398

399399
- [ ] Version bumped in `package.json`
400400
- [ ] `npm run compile` completed successfully

scripts/pre-release.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ async function main() {
158158
function updateContributingChecklist(filePath, version) {
159159
const newSection =
160160
`## Pre-Release Checklist\n\n` +
161-
`Run \`npm run pre-release\` to automate steps 1–2 below.\n\n` +
161+
`Run \`npm run pre-release\` to validate the version and compile.\n\n` +
162162
`- [ ] Version bumped in \`package.json\`\n` +
163163
`- [ ] \`npm run compile\` completed successfully\n` +
164164
`- [ ] Commit and push to main branch\n` +

0 commit comments

Comments
 (0)