Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Maturity Score webview to fully support theming and improve maintainability by replacing hardcoded colors and gradients with CSS variables. It also introduces semantic CSS classes for SVG chart elements and ensures that both dark and light themes are visually consistent and accessible.
The most important changes are:
Theming and CSS Refactor:
Replaced all hardcoded colors, gradients, and borders in
styles.csswith semantic CSS variables (e.g.,--bg-primary,--text-primary, etc.) to enable consistent theming across light and dark modes. This affects backgrounds, text, borders, buttons, and chart elements. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23]Added theme-specific overrides for light and high-contrast themes to ensure color contrast and readability, especially for stage and badge colors. [1] [2]
SVG & Chart Improvements:
Updated the radar chart rendering in
main.tsto use semantic CSS classes (e.g.,radar-grid,radar-label,radar-dot,radar-ring-label) instead of inline styles, allowing chart styling to be controlled via CSS and theme variables. [1] [2] [3]Injected the shared theme CSS into the webview at runtime to ensure theme variables are available. [1] [2]
These changes make the webview more maintainable, visually consistent, and ready for future theme customizations.