Skip to content

fix fluency viewer on ligth theme#413

Merged
rajbos merged 1 commit intomainfrom
fluency-light-theme
Mar 17, 2026
Merged

fix fluency viewer on ligth theme#413
rajbos merged 1 commit intomainfrom
fluency-light-theme

Conversation

@rajbos
Copy link
Copy Markdown
Owner

@rajbos rajbos commented Mar 17, 2026

This pull request updates the Maturity Score webview to fully support theming and improve maintainability by replacing hardcoded colors and gradients with CSS variables. It also introduces semantic CSS classes for SVG chart elements and ensures that both dark and light themes are visually consistent and accessible.

The most important changes are:

Theming and CSS Refactor:

  • Replaced all hardcoded colors, gradients, and borders in styles.css with semantic CSS variables (e.g., --bg-primary, --text-primary, etc.) to enable consistent theming across light and dark modes. This affects backgrounds, text, borders, buttons, and chart elements. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23]

  • Added theme-specific overrides for light and high-contrast themes to ensure color contrast and readability, especially for stage and badge colors. [1] [2]

SVG & Chart Improvements:

  • Updated the radar chart rendering in main.ts to use semantic CSS classes (e.g., radar-grid, radar-label, radar-dot, radar-ring-label) instead of inline styles, allowing chart styling to be controlled via CSS and theme variables. [1] [2] [3]

  • Injected the shared theme CSS into the webview at runtime to ensure theme variables are available. [1] [2]

These changes make the webview more maintainable, visually consistent, and ready for future theme customizations.

@rajbos rajbos enabled auto-merge March 17, 2026 20:15
@rajbos rajbos merged commit a7c9d03 into main Mar 17, 2026
13 checks passed
@rajbos rajbos deleted the fluency-light-theme branch March 17, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant