Skip to content

Fix all actionlint errors across workflow files#459

Merged
rajbos merged 2 commits intomainfrom
copilot/fix-action-lint-issues
Mar 22, 2026
Merged

Fix all actionlint errors across workflow files#459
rajbos merged 2 commits intomainfrom
copilot/fix-action-lint-issues

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 22, 2026

Merge conflict markers were left in cli-build.yml from a prior merge, breaking YAML parsing. Additionally, shellcheck flagged quoting and style issues across 7 other workflow files.

Critical

  • cli-build.yml: Remove <<<<<<</=======/>>>>>>> conflict markers. Resolve in favor of matrix strategy ([18, 20, 22]) and retain the diagnostics validation step from the feature branch.

Shellcheck fixes

  • SC2086 — Quote $GITHUB_OUTPUT, $GITHUB_STEP_SUMMARY, ${GITHUB_WORKSPACE} across check-models, release, sync-release-notes, sync-toolnames, validate-skills
  • SC2126grep | wc -lgrep -c in check-models.yml
  • SC2129 — Individual >> file redirects → { … } >> file blocks in cli-publish.yml, release.yml
  • SC2012/SC2035ls *.vsixfind . -maxdepth 1 -name "*.vsix" in release.yml
  • SC2086 (array) — String-concatenated $ARGS → bash array "${ARGS[@]}" in copilot-setup-steps.yml:
# Before
ARGS="--storageAccount $AZURE_STORAGE_ACCOUNT"
ARGS="$ARGS --tableName $AZURE_TABLE_NAME"
node load-table-data.js $ARGS

# After
ARGS=(--storageAccount "$AZURE_STORAGE_ACCOUNT")
ARGS+=(--tableName "$AZURE_TABLE_NAME")
node load-table-data.js "${ARGS[@]}"

actionlint passes clean after these changes.

- cli-build.yml: remove merge conflict markers, use matrix strategy, keep diagnostics step
- check-models.yml: quote $GITHUB_OUTPUT, use grep -c instead of grep|wc -l
- cli-publish.yml: group redirects with { } >> file (SC2129)
- copilot-setup-steps.yml: convert ARGS string to bash array (SC2086)
- release.yml: quote $GITHUB_OUTPUT/$GITHUB_STEP_SUMMARY, group redirects, use find instead of ls
- sync-release-notes.yml: quote $GITHUB_OUTPUT
- sync-toolnames.yml: quote ${GITHUB_WORKSPACE} and $GITHUB_OUTPUT
- validate-skills.yml: quote $GITHUB_OUTPUT

Co-authored-by: rajbos <6085745+rajbos@users.noreply.github.com>
@rajbos rajbos marked this pull request as ready for review March 22, 2026 04:14
@rajbos rajbos enabled auto-merge (squash) March 22, 2026 04:14
@rajbos rajbos merged commit 2cd32b7 into main Mar 22, 2026
21 of 22 checks passed
@rajbos rajbos deleted the copilot/fix-action-lint-issues branch March 22, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants