Fix duplicate VS session guards and handle MessagePack files in all views#480
Closed
Fix duplicate VS session guards and handle MessagePack files in all views#480
Conversation
…es in all views Co-authored-by: rajbos <6085745+rajbos@users.noreply.github.com> Agent-Logs-Url: https://github.com/rajbos/github-copilot-token-usage/sessions/8de2970a-0975-40e4-a5a6-238ef727ab53
Copilot
AI
changed the title
[WIP] Implement normal views in Visual Studio extension
Fix duplicate VS session guards and handle MessagePack files in all views
Mar 25, 2026
Owner
|
Messed up the source branch, should have done after #482 , so closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Visual Studio session support added in #477 introduced duplicate condition checks and left the "📄 View" action in Diagnostics broken for VS sessions — clicking it attempted to parse binary MessagePack as JSONL, producing an error popup.
Fixes
Duplicate guards removed —
statSessionFileandestimateTokensFromSessioninextension.tseach had an unreachable secondisVSSessionFilecheck;getEditorBadgeClassandgetEditorIconindiagnostics/main.tshad the same.showFormattedJsonlFileVS support — VS session files are binary MessagePack, not JSONL. Added early-exit path that decodes the file viaVisualStudioDataAccessand presents it as readable JSON, consistent with the existingopenRawFilehandler in the log viewer:getEditorIcon('Visual Studio') === '🪟'inwebview-utils.test.ts.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
teststorage.blob.core.windows.net/opt/hostedtoolcache/node/20.20.1/x64/bin/node /opt/hostedtoolcache/node/20.20.1/x64/bin/node --require ./out/test/unit/vscode-shim-register.js --test-force-exit /home/REDACTED/work/github-copilot-token-usage/github-copilot-token-usage/out/test/unit/backend-blobUploadService.test.js(dns block)/opt/hostedtoolcache/node/20.20.1/x64/bin/node /opt/hostedtoolcache/node/20.20.1/x64/bin/node --require ./out/test/unit/vscode-shim-register.js --test-force-exit /home/REDACTED/work/github-copilot-token-usage/github-copilot-token-usage/out/test/unit/backend-blobUploadService.test.js --noprofile(dns block)/opt/hostedtoolcache/node/20.20.1/x64/bin/node /opt/hostedtoolcache/node/20.20.1/x64/bin/node --require ./out/test/unit/vscode-shim-register.js --test-force-exit /home/REDACTED/work/github-copilot-token-usage/github-copilot-token-usage/out/test/unit/backend-blobUploadService.test.js 3635,3690p /home/REDACTED/work/github-copilot-token-usage/github-copilot-token-usage/src/extension.ts /home/REDACTED/.cargo/bin/bash ; fs.cpSync('pacnode(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
Created from VS Code.
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.