fix: gate VS extension job and harden marketplace version check#571
Merged
fix: gate VS extension job and harden marketplace version check#571
Conversation
…lease workflow - Add job-level \if\ to \�uild-visualstudio\ so it only runs on tag pushes or when \�s_only == true\; manual VS Code-only releases no longer trigger the expensive VS extension build - Fix null-array panic in the VS Marketplace version check: safely dereference \�xtensions[0]\ before accessing \.versions\, treating a missing extension as a first-publish instead of falling through to the catch block - Change the catch block from warn-and-proceed to hard-fail so a failed Marketplace query can no longer silently allow a duplicate-version publish Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running
elease.yml\ with default settings (VS Code only intent), the \�uild-visualstudio\ job always ran because it had no job-level \if:\ guard — only
eeds: release. This caused two issues:
A secondary bug in the marketplace version check meant the null-array error was silently swallowed (\Cannot index into a null array), letting execution fall through to the publish step instead of stopping cleanly.
Changes