Fix gofmt compability#107
Open
jonaz wants to merge 1 commit into
Open
Conversation
Collaborator
|
Would you be up to add a gofmt check in the generated example on CI (see https://github.com/rakyll/statik/blob/master/.travis.yml#L13)? |
Resolves: rakyll#106
jonaz
force-pushed
the
fix-gofmt-compability
branch
from
b3a6fa7 to
c98fefe
Compare
Author
done! |
jcchavezs
reviewed
Feb 28, 2020
| @@ -6,9 +6,8 @@ import ( | |||
| "github.com/rakyll/statik/fs" | |||
| ) | |||
|
|
|||
|
|
|||
| const Web = "web" // static asset namespace | |||
Collaborator
There was a problem hiding this comment.
I am not sure this is needed because you use the literal "web" here but if you really need this constant then it should be private.
Author
There was a problem hiding this comment.
I only ran whats in .travis.yml and it generated that file. ( ./statik -f -src=./example/public -dest=./example/ -include=*.jpg,*.txt,*.html,*.css,*.js -ns=web)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #106