Windows 11 Start Menu Styler v1.5.2#4199
Merged
Merged
Conversation
m417z
commented
May 27, 2026
m417z
commented
Member
- Disabled the classic Start menu layout in the latest Windows 11 update. In the latest update, reverting to the classic layout (either with the mod or via ViVeTool flags) causes the Start menu to fail to open. At this point, it's unclear whether it's a temporary Windows issue, or if it's caused by the removal of the classic layout from Windows.
* Disabled the classic Start menu layout in the latest Windows 11 update. In the latest update, reverting to the classic layout (either with the mod or via ViVeTool flags) causes the Start menu to fail to open. At this point, it's unclear whether it's a temporary Windows issue, or if it's caused by the removal of the classic layout from Windows.
There was a problem hiding this comment.
Pull request overview
This PR bumps Windows 11 Start Menu Styler to v1.5.2 and mitigates a recent Windows 11 update regression by preventing the mod from forcing the classic Start menu layout on affected builds (where it can cause the Start menu to fail to open). It also refactors the style-variable registry plumbing to route through a StyleVariableState object.
Changes:
- Disable the classic Start menu layout options on newer Windows builds by gating them behind a main-module version check.
- Add version-resource parsing (
VerQueryValueetc.) and link againstversion(-lversion) to support the build gating. - Refactor global style-variable maps into a
StyleVariableStatecontainer and thread it through the variable-resolution/propagation code paths.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| StyleVariableState g_styleVariableState; | ||
|
|
||
| StyleVariableState* GetStyleVariableState() { |
Comment on lines
+10911
to
+10917
| if (!state) { | ||
| // The element's XamlRoot has already been destroyed (or was never | ||
| // available); the StyleVariableState entry has been or will be reaped, | ||
| // and there is nothing to clean up. New registrations (newDeps) are | ||
| // also dropped on the floor: without a state we cannot route | ||
| // propagations anyway. | ||
| return; |
Comment on lines
+11911
to
+11915
| if (!state) { | ||
| Wh_Log(L"No XamlRoot for %s, skipping", | ||
| winrt::get_class_name(element).c_str()); | ||
| return; | ||
| } |
Comment on lines
+13524
to
+13531
| case DisableNewStartMenuLayout::disableNewLayoutKeepPhoneLink: | ||
| case DisableNewStartMenuLayout::disableNewLayoutAndPhoneLink: | ||
| if (IsMainModuleVersionAtLeast(10, 0, 26100, 8521)) { | ||
| // Classic Start Menu layout causes a crash in StartDocked.dll | ||
| // in newer builds, and as a result, the Start menu fails to | ||
| // launch. Disable the option in this case. | ||
| disableNewStartMenuLayout = | ||
| DisableNewStartMenuLayout::windowsDefault; |
drgutman
pushed a commit
to drgutman/windhawk-mods
that referenced
this pull request
Jun 1, 2026
* Disabled the classic Start menu layout in the latest Windows 11 update. In the latest update, reverting to the classic layout (either with the mod or via ViVeTool flags) causes the Start menu to fail to open. At this point, it's unclear whether it's a temporary Windows issue, or if it's caused by the removal of the classic layout from Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.