Common Controls Hook v1.0.1#4439
Merged
Merged
Conversation
m417z
commented
Jun 15, 2026
m417z
commented
Member
- Only apply the common controls to windows, not to controls such as buttons. Improves stability, and fixes a crash in Device Manager.
* Only apply the common controls to windows, not to controls such as buttons. Improves stability, and fixes a crash in Device Manager.
There was a problem hiding this comment.
Pull request overview
Updates the Common Controls Hook Windhawk mod to improve stability by reducing activation context churn and avoiding applying the Common Controls v6 activation context to child controls (e.g., buttons), addressing crashes such as in Device Manager.
Changes:
- Bumped mod version to 1.0.1 and made
ActCtxGuardnon-copyable/non-movable with explicit member initialization. - Reworked
CreateWindowExW/Ahooking to apply the activation context only for non-WS_CHILD(top-level) windows. - Added error logging when a function hook fails to install and cleaned up the hook-install macro with
#undef.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.