Better file sizes in Explorer details v1.5.1#4462
Merged
Merged
Conversation
m417z
commented
Jun 16, 2026
m417z
commented
Member
- Fixed the IEC terms option not working in some cases.
- Fixed slow file list loading with mapped network drives.
- Excluded msedgewebview2.exe to work around a reported incompatibility with Bitdefender which could cause the Start menu search to load indefinitely.
- Excluded Windhawk as an additional safety measure to allow disabling the mod if it's stuck on init.
* Fixed the IEC terms option not working in some cases. * Fixed slow file list loading with mapped network drives. * Excluded msedgewebview2.exe to work around a reported incompatibility with Bitdefender which could cause the Start menu search to load indefinitely. * Excluded Windhawk as an additional safety measure to allow disabling the mod if it's stuck on init.
There was a problem hiding this comment.
Pull request overview
This PR updates the “Better file sizes in Explorer details” Windhawk mod to v1.5.1, focusing on correctness and robustness around IEC unit formatting and performance when calculating folder sizes on network locations, plus safety exclusions for known-problematic processes.
Changes:
- Broadened IEC “KiB/MiB/…” formatting support by hooking additional propsys formatting (
PSStrFormatByteSizeWin addition toPSStrFormatKBSizeW) and improved buffer-space checks when appendingi. - Improved folder size resolution behavior for network locations by detecting mapped network drives in addition to UNC paths.
- Added additional
@excludeentries (e.g.,msedgewebview2.exe,windhawk.exe) and refreshed mod metadata/documentation strings.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2440
to
+2443
| int len = wcslen(pwszText); | ||
| if (len < 2 || pwszText[len - 1] != 'B') { | ||
| return ret; | ||
| } |
Comment on lines
2479
to
2482
| int len = wcslen(pwszText); | ||
| if (len < 2 || (size_t)len + 1 > cchText - 1 || pwszText[len - 2] != 'K' || | ||
| pwszText[len - 1] != 'B') { | ||
| if (len < 2 || pwszText[len - 2] != 'K' || pwszText[len - 1] != 'B') { | ||
| return ret; | ||
| } |
| } | ||
|
|
||
| return wcslen(lpBuffer); | ||
| return stringLen; |
Comment on lines
2736
to
2739
| void** ppCxaThrow = FindImportPtr(module, "libc++.dll", "__cxa_throw"); | ||
| if (!ppCxaThrow) { | ||
| wsprintf(errorMsg, L"No __cxa_throw"); | ||
| return false; | ||
| } |
Comment on lines
+2942
to
+2946
| auto pPSStrFormatByteSizeW = | ||
| (PSStrFormatByteSizeW_t)GetProcAddress(propsysModule, (PCSTR)421); | ||
| WindhawkUtils::Wh_SetFunctionHookT(pPSStrFormatByteSizeW, | ||
| PSStrFormatByteSizeW_Hook, | ||
| &PSStrFormatByteSizeW_Original); |
Comment on lines
+2948
to
+2952
| auto pPSStrFormatKBSizeW = | ||
| (PSStrFormatKBSizeW_t)GetProcAddress(propsysModule, (PCSTR)422); | ||
| WindhawkUtils::Wh_SetFunctionHookT(pPSStrFormatKBSizeW, | ||
| PSStrFormatKBSizeW_Hook, | ||
| &PSStrFormatKBSizeW_Original); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.