Common Controls Hook v1.0.2#4470
Merged
Merged
Conversation
m417z
commented
Jun 17, 2026
m417z
commented
Member
- Common Controls v6 activation is now skipped if already activated, improving stability.
* Common Controls v6 activation is now skipped if already activated, improving stability.
There was a problem hiding this comment.
Pull request overview
This PR updates the Common Controls Hook Windhawk mod to avoid activating its own Common Controls v6 activation context when v6 is already active in the current thread, aiming to reduce activation stack churn and improve stability.
Changes:
- Added logic to detect the currently active Common Controls “versioned” window class redirection (via activation context lookup).
- Cached the mod’s v6 “versioned” class name and used it to skip redundant
ActivateActCtxcalls. - Bumped mod version to 1.0.2.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+74
to
+82
| const auto* redirect = | ||
| static_cast<const wndclass_redirect_data*>(data.lpData); | ||
| if (redirect->name_offset >= data.ulLength) { | ||
| return std::wstring(); | ||
| } | ||
|
|
||
| const auto* name = reinterpret_cast<const WCHAR*>( | ||
| static_cast<const BYTE*>(data.lpData) + redirect->name_offset); | ||
| return std::wstring(name); |
Comment on lines
+161
to
+164
| if (!v6Name.empty() && ambient == v6Name) { | ||
| DeactivateActCtx(0, cookie); | ||
| return; | ||
| } |
|
Hello? Can you view my PR on taskbar guide? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.