feat: Parse capitalized boolean strings#228
Open
Tau2C wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While integrating
openidconnect-rs, I encountered responses where boolean fields are returned as strings (which is already handled by a feature flag), but they were additionally capitalized ("True"/"False").This caused deserialization to fail, even though the meaning of the values is obvious.
This is my first PR to an open-source project, so apologies if I’m missing any details or conventions.
If you have any suggestions regarding the implementation, scope, or preferred approach (e.g. feature-gating), I’ll be happy to adjust the PR accordingly.