Update reports.py#279
Conversation
Fix how the active variable is set.
|
Please accept this pull request. The default setting for |
|
Since this library no longer seems to be maintained, we have created a duplicate of it that we plan to maintain and improve over time. If you'd like to use our version check it out here: https://github.com/Lumiwealth/quantstats_lumi Please feel free to fork and send your pull request to this new library, we will be actively monitoring the library and approving PRs |
|
@ranaroussi Can you tell me why this was closed? The corresponding issue #278 is still present in the current code. |
There was a problem hiding this comment.
This changes it back to the string version "False" which is incorrect.
kartiksubbarao
left a comment
kartiksubbarao
left a comment
There was a problem hiding this comment.
Looks like one of the lines was inadvertently reverted back to the incorrect "False" version.
|
In addition to this, I found some other places in reports.py where an incorrect "False" string is used, I will open another issue for that. |
4 participants
Fix how the active variable is set, closes #278