Fix EOY Returns bar chart misalignment with x-axis labels#515
Open
edparcell wants to merge 1 commit intoranaroussi:mainfrom
Open
Fix EOY Returns bar chart misalignment with x-axis labels#515edparcell wants to merge 1 commit intoranaroussi:mainfrom
edparcell wants to merge 1 commit intoranaroussi:mainfrom
Conversation
When plotting yearly returns as a bar chart, the x-axis tick labels were misaligned with the bars. This happened because pandas df.plot(kind='bar') with a DatetimeIndex positions bars at internal integer offsets (e.g. 30, 31, 32...) rather than starting at 0. The label-thinning code then placed labels at np.arange(len(years)) (0, 1, 2...), causing labels to cluster on the left while bars appeared on the right. Fix: use ax.get_xticks() to get the actual bar positions instead of assuming they start at 0.
Author
|
Before: After: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
df.plot(kind='bar')with aDatetimeIndexpositions bars at internal integer offsets (e.g. 30, 31, 32...) rather than starting at 0. The label-thinning code inplot_returns_bars()then placed labels atnp.arange(len(years))(0, 1, 2...), creating a mismatch.Fix
Use
ax.get_xticks()to get the actual bar positions instead of assuming they start at 0. One-line change inquantstats/_plotting/core.py.🤖 Generated with Claude Code