Skip to content

Commit 3730179

Browse files
committed
fix: Update CI workflows to exclude planning docs and improve stub detection
Fixes two failing CI workflows: 1. Smoke Tests - Exclude planning documents: - Skip .work/ directory (planning docs like WAVE_10_INCOMPLETE.md) - Skip root-level markdown files (AGENT_A4_REPORT.md, RESOURCES_PROOF_OF_CONCEPT.md, etc.) - These are not skill files and don't need frontmatter 2. Validate Level 3 Resources - Improve stub detection: - Only flag 'stub' in comments or strings indicating incomplete work - Don't flag legitimate uses like gRPC stubs (self.stub = ServiceStub(...)) - More intelligent pattern matching for incomplete code 3. Fix executable permission: - chmod +x skills/workflow/project-synthesis/resources/scripts/extract_concepts.py All skills-related markdown files still validated, but planning/meta documents appropriately excluded.
1 parent 7f9c053 commit 3730179

3 files changed

Lines changed: 14 additions & 2 deletions

File tree

.github/workflows/smoke-tests.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,16 @@ jobs:
6767
skipped += 1
6868
continue
6969
70+
# Skip .work directory (planning documents)
71+
if ".work" in skill_file.parts:
72+
skipped += 1
73+
continue
74+
75+
# Skip root-level markdown files (planning docs, reports, etc.)
76+
if len(skill_file.parts) == 1:
77+
skipped += 1
78+
continue
79+
7080
# Skip commands directory (slash commands don't need skill frontmatter)
7181
if "commands" in skill_file.parts:
7282
skipped += 1

.github/workflows/validate-resources.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,10 @@ jobs:
159159
echo "⚠️ $script: Contains TODO comments"
160160
((found++))
161161
fi
162-
if grep -qi '\bstub\b' "$script"; then
163-
echo "⚠️ $script: Contains 'stub' references"
162+
# Only flag "stub" in comments or strings indicating incomplete work
163+
# Don't flag legitimate uses like gRPC stubs (e.g., "self.stub = ...")
164+
if grep -qiE '(#.*\bstub\b|""".*\bstub\b|stub.*implementation|implement.*stub)' "$script"; then
165+
echo "⚠️ $script: Contains 'stub' in comments/strings"
164166
((found++))
165167
fi
166168
if grep -qiE '\bmock\b.*\bimplementation\b' "$script"; then

skills/workflow/project-synthesis/resources/scripts/extract_concepts.py

100644100755
File mode changed.

0 commit comments

Comments
 (0)