Fixes #120 - Flattening argv errors on leaked shopts from mkinitcpio#121
Open
jaybent wants to merge 1 commit into
Open
Fixes #120 - Flattening argv errors on leaked shopts from mkinitcpio#121jaybent wants to merge 1 commit into
jaybent wants to merge 1 commit into
Conversation
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
argvflattening by separating "what to execute" and the logging of it:"$@"- the real commandargv, used for executioncommand- a printable representation of$@, used only for logsPR #119 is a related but incomplete re-implementation of the
sedworkflow.Background
mkinitcpiov41 introduced a bug wherenullglobwas set globally and not reset: 4d516794Fixed in: 0647e9f0