Highlight current word#37
Open
ahnwarez wants to merge 3 commits into
Open
Conversation
Owner
|
Sorry, for the late reply. Thanks for this interesting/useful PR! Will test/review asap this week. Cheers |
|
Perhaps revisit? |
|
Would love to see this change make it in. Literally came to this repo to see if I could contribute exactly this. |
|
I like this contribution. Added it to my fork (https://github.com/emilkm/ngram-type). You can test/use it here https://kesten.nz/ngram-type |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, I want to say thank you for making this awesome app. I always recommend it to my students who want improve touch typing.
This PR highlights the current word in white color, but future and past words are in muted color.
The reason for making this PR is that my eyes kinda get lost when I practice longer combinations (higher than ten) and I though maybe adding a visual indication could help other users to stay focused.
This is my first PR so any feedback is welcomed.