Skip to content

refactor: remove dependency to legacy provider on get signers#1164

Open
RyukTheCoder wants to merge 1 commit into
nextfrom
refactor/rf-2126-remove-dependency-to-legacy-provider-on-get-signers
Open

refactor: remove dependency to legacy provider on get signers#1164
RyukTheCoder wants to merge 1 commit into
nextfrom
refactor/rf-2126-remove-dependency-to-legacy-provider-on-get-signers

Conversation

@RyukTheCoder
Copy link
Copy Markdown
Contributor

Summary

Partially removed the dependency to legacy provider on getSigners method in useHubAdapter. As the first step, the dependency for EVM and Solana namespace is removed in this PR and the dependency for other namespaces will be removed as well.

Key changes

  • Register new hub specific signers in getSigners method of useHubAdapter
  • Added getInstance, signMessage, sendTransaction actions to EVM namespace in wallets/core and Phantom provider
  • Added getInstance, signMessage, signTransaction actions to Solana namespace in wallets/core and Phantom provider

How did you test this change?

Tested by signing and sending transactions on evm and solana blockchains.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants