refactor: remove dependency to legacy provider on get signers#1164
Open
RyukTheCoder wants to merge 1 commit into
Open
refactor: remove dependency to legacy provider on get signers#1164RyukTheCoder wants to merge 1 commit into
RyukTheCoder wants to merge 1 commit into
Conversation
792fbad to
a496f61
Compare
7099583 to
a77ea82
Compare
a77ea82 to
642a45f
Compare
9431967 to
6507542
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partially removed the dependency to legacy provider on getSigners method in useHubAdapter. As the first step, the dependency for EVM and Solana namespace is removed in this PR and the dependency for other namespaces will be removed as well.
Key changes
getInstance,signMessage,sendTransactionactions to EVM namespace inwallets/coreand Phantom providergetInstance,signMessage,signTransactionactions to Solana namespace inwallets/coreand Phantom providerHow did you test this change?
Tested by signing and sending transactions on evm and solana blockchains.
Checklist: