Tiny new features, more robust localization#35
Open
tjbcg wants to merge 3 commits into
Open
Conversation
What changed: - UI Localization now goes through Localizable strings. This is to avoid having to propagate changes on Base UI to all languages manually, since the UI is simple enough to not have to make language-specific UI choices - Added an option to show battery percentage instead of "Calculating..." when the remaining time is yet-to-be-determined. - Split option to show remaining time in two separate options depending on wether the computer is on battery or on AC power - Began making the notification system more customisable: all percentages are available (missing: modal to add a percentage, working: deleting percentages from the list) - Stop depending on Carthage (LaunchAtLogin is deprecating its Carthage support, and Xcode handles dependencies well)
Author
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed:
Please let me know if there are things that should be reviewed further