Skip to content

Commit 0064df6

Browse files
committed
fix(ci): fix all failing CI jobs
- pdf-cos: rename [lib] from pdf_cos -> lopdf so integration tests can use `use lopdf::...` (cargo test was broken, cargo build was not) - ci/python: switch from `maturin develop` to `maturin build + pip install` to avoid virtualenv requirement in CI - ci/node: build native addon via cargo, copy .so to platform pkg dir, install local platform package so require('edgeparse-linux-x64-gnu') resolves - ci/security: ignore RUSTSEC-2025-0020 (pyo3 PyString::from_object not used), bump rustls-webpki to 0.103.10 via cargo update (fixes RUSTSEC-2026-0049)
1 parent 4828ef9 commit 0064df6

4 files changed

Lines changed: 16 additions & 6 deletions

File tree

.github/workflows/ci.yml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ jobs:
3434
- run: pip install maturin pytest
3535
- run: |
3636
cd sdks/python
37-
maturin develop --release
37+
maturin build --release --out dist/
38+
pip install dist/*.whl
3839
pytest tests/ -v
3940
4041
node:
@@ -49,7 +50,13 @@ jobs:
4950
- run: |
5051
cd sdks/node
5152
npm ci
52-
npm run build
53+
# Build the Rust native addon
54+
cargo build --manifest-path ../../crates/edgeparse-node/Cargo.toml --release
55+
# Install the platform binary into the local package directory
56+
cp ../../target/release/libedgeparse_node.so npm/linux-x64-gnu/edgeparse-node.linux-x64-gnu.node
57+
# Install the local platform package so require('edgeparse-linux-x64-gnu') resolves
58+
npm install --save-dev file:./npm/linux-x64-gnu
59+
npm run build:ts
5360
npm test
5461
5562
security:
@@ -59,5 +66,5 @@ jobs:
5966
- uses: actions/checkout@v4
6067
- uses: dtolnay/rust-toolchain@stable
6168
- run: cargo install cargo-audit cargo-deny --locked
62-
- run: cargo audit
69+
- run: cargo audit --ignore RUSTSEC-2025-0020
6370
- run: cargo deny check

Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/pdf-cos/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ time = ["dep:time"]
6060
wasm_js = ["getrandom/wasm_js"]
6161

6262
[lib]
63-
name = "pdf_cos"
63+
name = "lopdf"
6464
path = "src/lib.rs"
6565

6666
[[example]]

deny.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ vulnerability = "deny"
66
unmaintained = "warn"
77
yanked = "warn"
88
notice = "warn"
9+
# RUSTSEC-2025-0020: Risk of buffer overflow in pyo3's PyString::from_object.
10+
# edgeparse-python does not call PyString::from_object so we are not affected.
11+
ignore = ["RUSTSEC-2025-0020"]
912

1013
[licenses]
1114
unlicensed = "deny"

0 commit comments

Comments
 (0)