Select copy tool by session type on Linux#6
Open
mpeter50 wants to merge 1 commit intoraphaeltannous:masterfrom
Open
Select copy tool by session type on Linux#6mpeter50 wants to merge 1 commit intoraphaeltannous:masterfrom
mpeter50 wants to merge 1 commit intoraphaeltannous:masterfrom
Conversation
the former code selected xclip on wayland, and so copying was not working. keep former code too for compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The former code selected xclip when MPV was running in a wayland session, because the command was existing despite it, and so copying did not work. There is also a log message now to tell the user if the copy tool was not found; on my system wl-copy is not installed by default.
I have kept the former code for compatibility, in case xclip and wl-copy is used on systems where this environment variable is not used, but of course the fix wont apply there.