Draft: fix: broken tests#1543
Open
jficz wants to merge 24 commits into
Open
Conversation
Switch `set_system_backdrop` from the Windows 11 22H2+ DWM backdrop attribute (`DWMWA_SYSTEMBACKDROP_TYPE`) to the legacy `SetWindow CompositionAttribute` path with `ACCENT_ENABLE_BLURBEHIND`. The DWM path requires Windows 11 build 22523+; the legacy path works on Windows 10 v1809+ and every Windows 11 build, giving a consistent blur across all supported Windows versions. Dynamic-loads `SetWindowCompositionAttribute` from user32.dll via `GetProcAddress`; the symbol isn't in the public SDK. Falls back to a no-op when the function isn't present. Uses `AccentFlags = 2` (undocumented "use gradient color") so the tint renders properly — matches Tauri's `window-vibrancy` crate. Without it, blur ignores the gradient color and picks a washed-out default. Co-authored-by: NSPC911 <NSPC911@users.noreply.github.com>
Flake lock file updates:
• Updated input 'flake-parts':
'github:hercules-ci/flake-parts/f20dc5d' (2026-03-01)
→ 'github:hercules-ci/flake-parts/3107b77' (2026-04-01)
• Updated input 'flake-parts/nixpkgs-lib':
'github:nix-community/nixpkgs.lib/c185c7a' (2026-03-01)
→ 'github:nix-community/nixpkgs.lib/333c4e0' (2026-03-29)
• Updated input 'nixpkgs':
'github:NixOS/nixpkgs/b40629e' (2026-03-18)
→ 'github:NixOS/nixpkgs/4bd9165' (2026-04-14)
• Updated input 'rust-overlay':
'github:oxalica/rust-overlay/c807e83' (2026-03-21)
→ 'github:oxalica/rust-overlay/e611106' (2026-04-18)
* docs: add documentation to test_poll.rs * chore: remove test_echo_server.rs (fully commented out, no functional tests) * chore: remove test_close_on_drop.rs (fully commented out, no functional tests) * chore: remove test_double_register.rs (fully commented out, no functional tests) * chore: remove test_broken_pipe.rs (uses deprecated corcovado::deprecated module that no longer exists)
introduced in raphamorim#1535
Author
|
never mind, took me a while to realize what the test really did 🤦 |
Author
|
@raphamorim what happened to PR #1535? the commit is still on master but the PR is gone and so is, apparently, the user who created it... It's ... weird |
Author
|
switching to Draft as the PR which removed the affected tests looks a bit suspicious |
Owner
|
hmm weird for real, i reset the main just in case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem introduced in #1535
Fixes #1544