fix(macos): SKK direct input lost and IME mode-switch keys leaking to shell#1561
Open
shiena wants to merge 2 commits intoraphamorim:mainfrom
Open
fix(macos): SKK direct input lost and IME mode-switch keys leaking to shell#1561shiena wants to merge 2 commits intoraphamorim:mainfrom
shiena wants to merge 2 commits intoraphamorim:mainfrom
Conversation
shiena
force-pushed
the
feature/macos-forward-to-ime-modifier-mask
branch
from
ddbe419 to
25af40e
Compare
shiena
changed the title
shiena
force-pushed
the
feature/macos-forward-to-ime-modifier-mask
branch
6 times, most recently
from
8b0dffe to
304eede
Compare
shiena
force-pushed
the
feature/macos-forward-to-ime-modifier-mask
branch
4 times, most recently
from
1034e3b to
db5884a
Compare
- gate interpretKeyEvents: forwarding by a configurable modifier mask - handle IME direct commits without preedit (e.g. SKK kana mode) - swallow keys consumed via IMKTextInput.selectMode (SKK Ctrl+J, q)
shiena
force-pushed
the
feature/macos-forward-to-ime-modifier-mask
branch
from
db5884a to
37a59de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1560.
Summary
Three macOS IME fixes for SKK-derived input methods (macSKK, AquaSKK) plus a new configurable modifier mask that decides which key events are forwarded to
interpretKeyEvents:.Behavior changes
ain hiragana mode insertsあinstead ofa.Ctrl+J,q, and other keys macSKK consumes viaIMKTextInput::selectMode()only no longer leak through as raw input —no stray newlines or letters when switching IME mode.New config
A key event is forwarded to the macOS IME when no modifier is pressed, or when the pressed modifiers intersect this mask.
The default keeps the historical behavior, so existing setups are unaffected.
Accepted values (case-insensitive):
shift,ctrl(aliascontrol),alt(aliasoption),super(aliasescmd,command).Recommended for SKK users:
This lets
Ctrl+J,Ctrl+G,Shift+letterreach the IME while keepingCmd+keyandAlt+keyfor terminal shortcuts.