feat: configurable tab bar height via navigation.tab-bar-height#1683
Open
cantona wants to merge 3 commits into
Open
feat: configurable tab bar height via navigation.tab-bar-height#1683cantona wants to merge 3 commits into
cantona wants to merge 3 commits into
Conversation
The tab-strip title size was hardcoded to TITLE_FONT_SIZE = 12.0. Add a `tab-font-size` option under [navigation] (default 12) threaded into the Island renderer, and apply it on config hot-reload alongside the tab colors.
The tab/navigation bar height was a hardcoded ISLAND_HEIGHT const (34px). Replace it with a navigation.tab-bar-height config option (default 34) plumbed through to the Island and the hit-test sites, so the tab bar can be resized. Mirrors the existing navigation.tab-font-size option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
navigation.tab-bar-heightconfig option (default 34) to set the height of the tab/navigation bar (the 'island'), in logical pixels. Previously the height was a hardcodedISLAND_HEIGHTconst. The value is plumbed through to the Island renderer and the top-bar hit-test sites, and hot-reloads on config change. Mirrors the existingnavigation.tab-font-sizeoption.Note: stacked on the tab-font-size work (#1681), so it includes that commit; the tab-bar-height commit is the last one. Happy to rebase onto main once #1681 lands.