fix: hot-reload window.decorations without restart#1684
Open
cantona wants to merge 2 commits into
Open
Conversation
configure_window() (run on every config reload) re-applied opacity, blur, title, etc. but never decorations, so toggling window.decorations only took effect at window creation. Call set_decorations() there too so it reloads live like the other window settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configure_window()runs on every config reload and re-applies window settings (opacity, blur, transparency, title, corner preference, …) — but it never re-applieddecorations, so togglingwindow.decorationsonly took effect at window creation and required a restart.Add a
set_decorations()call there, mirroring the build-time mapping (onlyDisabledturns server-side decorations off), so the setting hot-reloads live like the others.Standalone, based on main.