fix: keep quit-confirmation dialog visible on idle frames#1685
Closed
cantona wants to merge 1 commit into
Closed
Conversation
The ConfirmQuit dialog is drawn into sugarloaf before screen.render(),
but render() calls discard_frame() whenever should_present is false
(no panel damage and no animation) -- which is exactly the case while
the dialog is up on an idle terminal. The dialog was thrown away and
only appeared on frames a cursor blink happened to force, so it
flickered in and out ('sometimes cannot see it'). Add a force_present
flag to render(), set while in ConfirmQuit, so the dialog frame is
always presented.
Author
|
no needed. 89c5744 fixed it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ConfirmQuit dialog is drawn into sugarloaf before
screen.render(), butrender()callsdiscard_frame()whenevershould_presentis false — i.e. no panel damage and no animation, which is exactly the case while the dialog is up over an idle terminal. The dialog draws were discarded and only reached the screen on frames a cursor blink (or other animation) happened to force, so the prompt flickered in and out ('sometimes I can't see it').Add a
force_presentflag torender(), set while the route isConfirmQuit, so the dialog frame is always presented.Standalone, based on main.