fix: recompute grid rows when the tab bar appears/disappears#1687
Open
cantona wants to merge 2 commits into
Open
fix: recompute grid rows when the tab bar appears/disappears#1687cantona wants to merge 2 commits into
cantona wants to merge 2 commits into
Conversation
Creating a tab toggles hide_if_single, which grows scaled_margin.top to make room for the tab bar. update_dimensions then re-laid out via apply_taffy_layout, but never refreshed Taffy's available height for the new margin -- so the grid kept its old (taller) row count and the bottom row was clipped off the window until a window resize (which calls try_update_size) corrected it. Refresh the Taffy size with the current scaled_margin in update_dimensions before laying out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
hide_if_singleis on, creating a second tab makes the tab bar appear, which growsscaled_margin.topto reserve its band. Butupdate_dimensionsre-laid out viaapply_taffy_layoutwithout refreshing Taffy's available height for the new margin — so the grid kept its previous (taller) row count and the bottom row was clipped off the bottom of the window. It only corrected itself after a window resize, becauseresize()callstry_update_size(which does push the new margin into Taffy).Fix:
update_dimensionsnow callstry_update_size(self.width, self.height)beforeapply_taffy_layout, so the available height accounts for the tab-bar band and the row count is recomputed. Also fixes the reverse transition (closing back to one tab).Standalone, based on main.