fix: repaint immediately when a tab closes on shell exit#1688
Open
cantona wants to merge 2 commits into
Open
Conversation
When a tab's shell exits, the PTY thread sends CloseTerminal(route_id) and a separate Render. The CloseTerminal handler closed the tab and resized the strip but never requested a redraw of its own -- so if the Render was processed first (or coalesced), the closed tab lingered on screen showing the dead shell until a later event (e.g. clicking another tab) forced a repaint. Mark dirty + request redraw in the close handler so the post-close state is presented immediately.
Author
|
Fix issue #1661 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With several tabs open, typing
exitin a tab sometimes closed it instantly and sometimes left it frozen on screen (showing the dead shell) until you clicked another tab.On shell exit the PTY thread sends
CloseTerminal(route_id)and a separateRender. TheCloseTerminalhandler closed the tab and resized the strip but never requested a redraw itself — it relied on that separateRender. If theRenderwas processed beforeCloseTerminal(or coalesced away), the post-close state was never painted, so the closed tab lingered until a later event forced a repaint.Fix:
mark_dirty()+request_redraw()in theCloseTerminalhandler so the close is shown immediately, regardless of event ordering.Standalone, based on main.