fix: parse function-key and enter bindings in config [bindings]#1689
Open
cantona wants to merge 2 commits into
Open
fix: parse function-key and enter bindings in config [bindings]#1689cantona wants to merge 2 commits into
cantona wants to merge 2 commits into
Conversation
convert() (the [bindings] config parser) had no f1-f12, no "enter"
alias (only "return"), and no "backspace", so those keys hit the
catch-all Err arm and the binding was silently dropped -- e.g.
`{ key = "f11", action = "togglefullscreen" }` did nothing and F11
fell through to the terminal. Add the function keys, an enter alias, and
backspace, matching the set the hint-binding parser already accepts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function-key bindings in the
[bindings]config silently did nothing.convert()(the config key parser) had nof1-f12, noenteralias (onlyreturn), and nobackspace, so those keys hit the catch-allErrarm and the binding was dropped. For example:did nothing — F11 fell through to the terminal as its escape sequence.
Add
f1-f12, anenteralias, andbackspacetoconvert(), matching the key set the hint-binding parser already accepts.Standalone, based on main.