Update checkcodes and bug fixes

Author: adfoster-r7

modules/exploits/linux/http/nagios_xi_chained_rce_2_electric_boogaloo.rb

@@ -87,10 +87,10 @@ def check
       if @version < target[:lower_version]
         vprint_bad('Try nagios_xi_chained for this version.')
       elsif (@version <= target[:upper_version] && @version >= target[:lower_version])
-        return CheckCode::Appears("Version #{version} appears to be vulnerable")
+        return CheckCode::Appears("Version #{@version} appears to be vulnerable")
       end
     end
-    CheckCode::Safe("Version #{version} is not vulnerable")
+    CheckCode::Safe("Version #{@version} is not vulnerable")
   end
 
   def set_db_user(usr, passwd)

modules/exploits/linux/http/nagios_xi_mibs_authenticated_rce.rb

@@ -96,10 +96,10 @@ def check
     end
 
     if @version >= Rex::Version.new('5.6.0') && @version <= Rex::Version.new('5.7.3')
-      return CheckCode::Appears("Version #{version} appears to be vulnerable")
+      return CheckCode::Appears("Version #{@version} appears to be vulnerable")
     end
 
-    return CheckCode::Safe("Version #{version} is not vulnerable")
+    return CheckCode::Safe("Version #{@version} is not vulnerable")
   end
 
   def execute_command(cmd, _opts = {})

modules/exploits/linux/http/nagios_xi_plugins_check_plugin_authenticated_rce.rb

@@ -130,10 +130,10 @@ def check
     end
 
     if @version < Rex::Version.new('5.6.6')
-      return CheckCode::Appears("Version #{version} appears to be vulnerable")
+      return CheckCode::Appears("Version #{@version} appears to be vulnerable")
     end
 
-    return CheckCode::Safe("Version #{version} is not vulnerable")
+    return CheckCode::Safe("Version #{@version} is not vulnerable")
   end
 
   def grab_plugins_nsp

modules/exploits/linux/http/nagios_xi_plugins_filename_authenticated_rce.rb

@@ -97,10 +97,10 @@ def check
     end
 
     if @version < Rex::Version.new('5.8.0')
-      return CheckCode::Appears("Version #{version} appears to be vulnerable")
+      return CheckCode::Appears("Version #{@version} appears to be vulnerable")
     end
 
-    return CheckCode::Safe("Version #{version} is not vulnerable")
+    return CheckCode::Safe("Version #{@version} is not vulnerable")
   end
 
   def execute_command(cmd, _opts = {})

modules/exploits/linux/http/netis_unauth_rce_cve_2024_22729.rb

@@ -121,7 +121,7 @@ def check
 
       return CheckCode::Safe(version[2].chop.to_s)
     end
-    CheckCode::Safe("Version #{version} is not vulnerable")
+    CheckCode::Safe('Unable to parse target version from response')
   end
 
   def exploit

modules/exploits/linux/http/netis_unauth_rce_cve_2024_48456_and_48457.rb

@@ -212,7 +212,7 @@ def check
         return CheckCode::Safe(version[1].to_s)
       end
     end
-    CheckCode::Safe("Version #{version} is not vulnerable")
+    CheckCode::Safe('Target version is not vulnerable')
   end
 
   def exploit

modules/exploits/linux/http/php_imap_open_rce.rb

@@ -97,7 +97,7 @@ def check
         return
       end
 
-      if res.code = 200
+      if res.code == 200
         return CheckCode::Detected('The target service was detected')
       end
     elsif target.name =~ /Horde IMP H3/
@@ -246,7 +246,7 @@ def exploit
         return
       end
 
-      if res.code = 200
+      if res.code == 200
         cookie = res.get_cookies
       else
         print_error("HTTP code #{res.code} found, check options.")

modules/exploits/linux/http/pineapple_preconfig_cmdinject.rb

@@ -241,13 +241,13 @@ def check
         'method' => 'GET',
         'uri' => brute_uri
       )
-      return Exploit::CheckCode::Safe('The target is not vulnerable') if !brutecheck || !brutecheck.code == 200 || brutecheck.body !~ /own this pineapple/
+      return Exploit::CheckCode::Safe('The target is not vulnerable') if !brutecheck || brutecheck.code != 200 || brutecheck.body !~ /own this pineapple/
 
       return Exploit::CheckCode::Vulnerable('The target is vulnerable')
     end
 
     cmd_success = cmd_inject("echo")
-    return Exploit::CheckCode::Vulnerable('The target is vulnerable') if cmd_success && cmdSuccess.code == 200 && cmd_success.body =~ /Executing/
+    return Exploit::CheckCode::Vulnerable('The target is vulnerable') if cmd_success && cmd_success.code == 200 && cmd_success.body =~ /Executing/
 
     Exploit::CheckCode::Safe('The target is not vulnerable')
   end

modules/exploits/linux/http/qnap_qts_rce_cve_2023_47218.rb

@@ -85,7 +85,7 @@ def check
     # </Errmsg>
     # </Storage>
 
-    return Exploit::CheckCode::Detected("Target detected: version #{version}") if res.body.include? '<Result>failure</Result>'
+    return Exploit::CheckCode::Detected('QNAP QTS target detected') if res.body.include? '<Result>failure</Result>'
 
     CheckCode::Unknown('Could not determine the target status')
   end

modules/exploits/linux/http/samsung_srv_1670d_upload_exec.rb

@@ -77,7 +77,7 @@ def check
       if resp.body =~ /File Version (\d+\.\d+\.\d+\.\d+)/
         version = $1
         if version == '1.0.0.193'
-          vprint_good "Found vesrion: #{version}"
+          vprint_good "Found version: #{version}"
           return CheckCode::Appears("Version #{version} appears to be vulnerable")
         end
       end