Add human-readable descriptions to CheckCode returns in multi/http exploit modules (A-O)

Author: adfoster-r7

modules/exploits/multi/http/activecollab_chat.rb

@@ -73,10 +73,10 @@ def check
     if (cms and cms.body =~ /powered by activeCollab/)
       # detect the chat module
       if (chat and chat.code == 200)
-        return Exploit::CheckCode::Detected
+        return Exploit::CheckCode::Detected('The target application was detected but the version could not be confirmed as vulnerable')
       end
     end
-    return Exploit::CheckCode::Safe
+    return Exploit::CheckCode::Safe('The target is not running a vulnerable version')
   end
 
   def exploit

modules/exploits/multi/http/adobe_coldfusion_rce_cve_2023_26360.rb

@@ -154,7 +154,7 @@ def check
       return CheckCode::Detected('ColdFusion detected but version number is unknown.')
     end
 
-    CheckCode::Unknown
+    CheckCode::Unknown('Could not connect to the target')
   end
 
   def exploit

modules/exploits/multi/http/agent_tesla_panel_rce.rb

@@ -163,16 +163,16 @@ def check
     if response
       if response.redirect? && response.headers['location'] =~ /login.php/ && !(datastore['USERNAME'] && datastore['PASSWORD'])
         print_warning('Unauthenticated RCE can\'t be exploited, retry if you gain CnC credentials.')
-        return Exploit::CheckCode::Unknown
+        return Exploit::CheckCode::Unknown('No response received from the target')
       end
 
       rand_str = Rex::Text.rand_text_alpha(8..16)
       cmd_output = parse_response(execute_command("echo #{rand_str}"))
 
-      return Exploit::CheckCode::Vulnerable if cmd_output.include?(rand_str)
+      return Exploit::CheckCode::Vulnerable('Successfully executed a command on the target') if cmd_output.include?(rand_str)
     end
 
-    Exploit::CheckCode::Safe
+    Exploit::CheckCode::Safe('The target is not vulnerable')
   end
 
   def exploit

modules/exploits/multi/http/ajaxplorer_checkinstall_exec.rb

@@ -75,10 +75,10 @@ def check
 
     # If the server doesn't return the default redirection, probably something is wrong
     if res and res.code == 200 and res.body =~ /#{clue}/
-      return Exploit::CheckCode::Vulnerable
+      return Exploit::CheckCode::Vulnerable('Successfully verified path traversal vulnerability')
     end
 
-    return Exploit::CheckCode::Safe
+    return Exploit::CheckCode::Safe('The target is not vulnerable')
   end
 
   def exploit

modules/exploits/multi/http/apache_apisix_api_default_token_rce.rb

@@ -100,7 +100,7 @@ def check
 
     if server && server.match(/APISIX/)
       vprint_status("Found an #{server} #{version} http server header")
-      return Exploit::CheckCode::Appears if version > Rex::Version.new('2')
+      return Exploit::CheckCode::Appears('The target is running a vulnerable version') if version > Rex::Version.new('2')
     end
     return Exploit::CheckCode::Safe('A vulnerable version if APISIX server is not running')
   end

modules/exploits/multi/http/apache_druid_cve_2023_25194.rb

@@ -97,7 +97,7 @@ def check
       info: "Module #{fullname} found vulnerable host."
     })
 
-    Exploit::CheckCode::Vulnerable
+    Exploit::CheckCode::Vulnerable('Successfully verified code execution on the target')
   ensure
     cleanup_service
   end

modules/exploits/multi/http/apache_flink_jar_upload_exec.rb

@@ -79,7 +79,7 @@ def check
       return CheckCode::Appears("Apache Flink version #{version}.")
     end
 
-    CheckCode::Appears
+    CheckCode::Appears('The target appears to be a vulnerable version')
   end
 
   def delete_jar(filename)

modules/exploits/multi/http/apache_mod_cgi_bash_env_exec.rb

@@ -84,11 +84,11 @@ def check
     res = req("echo #{marker}", datastore['CVE'])
 
     if res && res.body.include?(marker * 3)
-      return Exploit::CheckCode::Vulnerable
+      return Exploit::CheckCode::Vulnerable('Successfully verified code execution on the target')
     elsif res && res.code == 500
       injected_res_code = res.code
     else
-      return Exploit::CheckCode::Safe
+      return Exploit::CheckCode::Safe('The target is not vulnerable')
     end
 
     res = send_request_cgi({
@@ -97,12 +97,12 @@ def check
     })
 
     if res && injected_res_code == res.code
-      return Exploit::CheckCode::Unknown
+      return Exploit::CheckCode::Unknown('Received an unexpected response from the target')
     elsif res && injected_res_code != res.code
-      return Exploit::CheckCode::Appears
+      return Exploit::CheckCode::Appears('The target appears to be vulnerable')
     end
 
-    Exploit::CheckCode::Unknown
+    Exploit::CheckCode::Unknown('No response received from the target')
   end
 
   def exploit

modules/exploits/multi/http/apache_roller_ognl_injection.rb

@@ -132,9 +132,9 @@ def check
     })
 
     if res and res.code == 200 and res.body =~ /#{sum}/
-      return Exploit::CheckCode::Vulnerable
+      return Exploit::CheckCode::Vulnerable('Successfully verified path traversal vulnerability')
     end
 
-    return Exploit::CheckCode::Safe
+    return Exploit::CheckCode::Safe('The target is not vulnerable')
   end
 end

modules/exploits/multi/http/apprain_upload_exec.rb

@@ -69,9 +69,9 @@ def check
     })
 
     if res and res.code == 200 and res.body.empty?
-      return Exploit::CheckCode::Appears
+      return Exploit::CheckCode::Appears('The target appears to be vulnerable based on the response')
     else
-      return Exploit::CheckCode::Safe
+      return Exploit::CheckCode::Safe('The target is not vulnerable')
     end
   end