Fix the Rex HTTP Server#21636
Open
zeroSteiner wants to merge 4 commits into
Open
Conversation
cgranleese-r7
approved these changes
Jul 3, 2026
adfoster-r7
reviewed
Jul 7, 2026
| # -*- coding: binary -*- | ||
| require 'uri' | ||
|
|
||
| require 'rex/text' |
Contributor
There was a problem hiding this comment.
Is this needed? I think it should be covered by:
metasploit-framework/lib/rex.rb
Lines 32 to 33 in dd081ab
Edit: I guess that you've added it because it's not included implicitly when running unit tests in isolation? 👀
Contributor
Author
There was a problem hiding this comment.
That's correct. I can't run the tests in isolation without that.
zeroSteiner
force-pushed
the
fix/mc2-http-rpc-response
branch
from
0f72a03 to
2228196
Compare
The context is now needed in the generic HTTP dispatch which is used by Pro and thus outside the context of an exploit.
zeroSteiner
force-pushed
the
fix/mc2-http-rpc-response
branch
from
2228196 to
2531106
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rex HTTP Server reads the context in the generic handler now. This breaks things in Pro because there's no context or exploit in the RPC server.
Includes basic tests to prevent regressions in the future.