fix: Modifying a frozen string cause an error in Exploit::Remote::Ftp mixin#21657
Closed
lxcxjxhx wants to merge 3 commits into
Closed
fix: Modifying a frozen string cause an error in Exploit::Remote::Ftp mixin#21657lxcxjxhx wants to merge 3 commits into
Exploit::Remote::Ftp mixin#21657lxcxjxhx wants to merge 3 commits into
Conversation
Modifying a frozen string cause an error in `Exploit::Remote::Ftp` mixin
The recv_ftp_resp method mutates @ftpbuff with <<, but initializing it as a literal string " makes it frozen when frozen_string_literal: true is enabled (new policy per AGENTS.md). Change @ftpbuff = " to @ftpbuff = String.new so the buffer remains mutable regardless of the frozen_string_literal pragma. This allows modules using this mixin to adopt the new pragma without breaking FTP operations.
Fixes rapid7#21597 When # frozen_string_literal: true is enabled, string literals are frozen and cannot be modified. Using String.new creates a mutable string that can be safely modified.
Author
|
Closing this PR to provide a higher-quality fix. The current changes don't adequately address issue #21597. I'll be reopening with a more thorough analysis and proper code fix including test coverage. Will resubmit shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #21597 - Modifying a frozen string causes an error in
Exploit::Remote::FtpmixinThe problem
When
# frozen_string_literal: trueis enabled (which is the default in modern Ruby), string literals like""are frozen and cannot be modified. This causes aFrozenErrorwhen the code tries to modify@ftpbufflater in therecv_ftp_respmethod.The fix
Changed line 33 in
lib/msf/core/exploit/remote/ftp.rb:@ftpbuff = ""@ftpbuff = String.newString.newcreates a mutable string that can be safely modified regardless of the frozen string literal setting.Testing
Checklist
Fixes #21597