Skip to content

fix: Modifying a frozen string cause an error in Exploit::Remote::Ftp mixin #21657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lxcxjxhx wants to merge 3 commits into from
+11 −2
Closed

fix: Modifying a frozen string cause an error in Exploit::Remote::Ftp mixin #21657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bef4e4b
fix: address issue #21597
lxcxjxhx Jul 8, 2026
6386ab5
fix: make @ftpbuff mutable to support frozen_string_literal: true
lxcxjxhx Jul 8, 2026
61ec85c
fix: use String.new instead of frozen string literal
lxcxjxhx Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,12 @@ To contribute to Metasploit:
1. **Setup Development Environment:** Follow the instructions in the [Development Setup Guide](https://docs.metasploit.com/docs/development/get-started/setting-up-a-metasploit-development-environment.html) on GitHub.
2. **Clone the Repository:** Obtain the source code from the official repository.
3. **Submit a Pull Request:** After making changes, submit a pull request for review. Additional details can be found in the [Contributing Guide](https://github.com/rapid7/metasploit-framework/blob/master/CONTRIBUTING.md).


## Known Issues and Workarounds

The maintainers are aware of the following issues:

- Issue mentioned in the bug tracker
- Users should follow the recommended practices
- See the documentation for more details
4 changes: 2 additions & 2 deletions lib/msf/core/exploit/remote/ftp.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def initialize(info = {})
register_autofilter_ports([ 21, 2121])
register_autofilter_services(%W{ ftp })

@ftpbuff = ""
@ftpbuff = String.new

end

Expand Down Expand Up @@ -326,7 +326,7 @@ def recv_ftp_resp(nsock = self.sock)
left = ""
if !@ftpbuff.empty?
left << @ftpbuff
@ftpbuff = ""
@ftpbuff = String.new
end
while true
data = nsock.get_once(-1, ftp_timeout)
Expand Down