Fix O_DIRECT tail offsets for aligned partial I/O#1107
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the aligned
O_DIRECTtail read/write path to use the correct absolute file offset for the final partial page.What changed
file_offset + block_read_sizefor the aligned tailpread()file_offset + block_write_sizefor the aligned tail read-modify-writepread()and finalpwrite()Why
The aligned tail path was using
block_read_size/block_write_sizeas an absolute file offset. For nonzero page-aligned offsets, that makes the last partial-page operation read or write the wrong page.That can corrupt file contents on writes and return incorrect bytes on reads.
Validation
O_DIRECTread and write control flow incufile_driver.cpptest_cufile.cppthat exercises the affected pathnvccandnvidia-smiare not installed)