Commit e5b4e1d
authored
fix(ci): use sha for the only allowlisted version of action-add-assignees (#22453)
I can't tell if this is right, because that repo has weird tags:
```
🐚 git ls-remote https://github.com/actions-ecosystem/action-add-assignees refs/tags/*
59970ef501a38f91ea9afa2993b44162e33b3eac refs/tags/v1
ce5019e63cc4f35aba27308dc88d19c8f3686747 refs/tags/v1^{}
60aa57ae61b8fc53785076d0fc7327a6ef3a06fd refs/tags/v1.0.0
ce5019e63cc4f35aba27308dc88d19c8f3686747 refs/tags/v1.0.0^{}
48956ae0c11159427139404f968c4686dd245cfd refs/tags/v1.0.1
a5b84af721c4a621eb9c7a4a95ec20a90d0b88e9 refs/tags/v1.0.1^{}
```
Only the `@v1` mutable ref is allow-listed in the org-wide actions settings, so maybe the tag pointing to `v1.0.0` messes it up?
The action that allowed is listed as:
`actions-ecosystem/action-add-assignee@v1`
It is unclear to me if that `@v1` will allow a commit SHA that points to the same location that the `@v1` tag points. I would've thought so, but the current SHA on `main` _does_ point to the same location:
```
gforsyth …/action-add-assignees main 13:29
🐚 git checkout v1
HEAD is now at ce5019e Update action.yml (#3)
gforsyth …/action-add-assignees HEAD 13:29
🐚 git rev-parse HEAD
ce5019e63cc4f35aba27308dc88d19c8f3686747
```
It's possible (and what this PR currently changes) that the _commented_ tag corresponding to that SHA is causing the issue here, since `v1.0.0` isn't explicitly allowed (despite being the same commit):
```
* ce5019e - (HEAD, tag: v1.0.0, tag: v1) Update action.yml (#3) (6 years ago) <micnncim>
```
The other option is that the `@v1` only allows resolving the SHA of that git tag object itself (the tag, not what it points to), which is `59970ef501a38f91ea9afa2993b44162e33b3eac`. Does the SHA of a tag object change if the tag is mutated to point to a different commit? I don't know.
Authors:
- Gil Forsyth (https://github.com/gforsyth)
Approvers:
- Bradley Dice (https://github.com/bdice)
URL: #224531 parent 57e27e7 commit e5b4e1d
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
0 commit comments