Commit af70615
authored
Fix hanging pytests (#1924)
This PR attempts to fix the hanging pytest issues we are seeing in CI.
From my investigations there are two issues.
One is the `test_cagra_ace_tiny_memory_limit_triggers_disk_mode` and `test_hnsw_ace_tiny_memory_limit_triggers_disk_mode` tests which I have seen locally to hang. ~~At the moment, I am skipping these pytests in CI.~~
**Update**: After testing here 20 times https://github.com/rapidsai/cuvs/actions/runs/23182916436?pr=1893, I don't think we need to skip these tests.
Second is a memory out of bounds error in `device_matrix_view_from_host` , first revealed by compute-sanitizer. This is likely a HMM issue. I have added more specific checks in the constructor so a copy is used when necessary.
See this CI run from my test PR where I run 10 times to ensure that CI works with these fixes.
https://github.com/rapidsai/cuvs/actions/runs/23131230353
I also reran CI on that test PR again. So all the pytests were run 20 times.
Authors:
- Anupam (https://github.com/aamijar)
Approvers:
- Tarang Jain (https://github.com/tarang-jain)
URL: #19241 parent 2687c99 commit af70615
1 file changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
174 | 174 | | |
175 | 175 | | |
176 | 176 | | |
177 | | - | |
178 | | - | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
179 | 181 | | |
180 | 182 | | |
181 | 183 | | |
| |||
0 commit comments