Migrate from pynvml to cuda.core.system#1645
Conversation
60446f5 to
505f227
Compare
505f227 to
1306c08
Compare
|
/ok to test 1306c08 |
|
/ok to test 00453df |
TomAugspurger
left a comment
There was a problem hiding this comment.
Looks nice overall.
IMO, the changes to dask_cuda.utils (removal of unpack_bitmask, change in return types) aren't worth trying to deprecate.
pentschev
left a comment
There was a problem hiding this comment.
IMO, the changes to dask_cuda.utils (removal of unpack_bitmask, change in return types) aren't worth trying to deprecate.
Yes, absolutely not worth it, just removing them (as is being proposed) is enough.
@mdboom it seems you're still missing some cuda-core pinning changes:
Lines 257 to 266 in c0f9a3f
-And since we're upgrading the version of cuda-core it would be nice to properly handle (i.e., remove) previous compatibility changes:
dask-cuda/dask_cuda/initialize.py
Lines 12 to 15 in c0f9a3f
dask-cuda/dask_cuda/_compat.py
Lines 22 to 29 in c0f9a3f
As well as in the following test files:
- https://github.com/rapidsai/dask-cuda/blob/main/dask_cuda/tests/test_initialize.py
- https://github.com/rapidsai/dask-cuda/blob/main/dask_cuda/tests/test_utils.py
Could you do that?
|
/ok to test 97bfb94 |
|
/ok to test 97bfb94 |
|
/ok to test 3933543 |
This migrates from pynvml to the new Cython/cybind-based bindings for NVML in
cuda.core.system.