Skip to content

Check remote range end arithmetic#986

Open
fallintoplace wants to merge 1 commit into
rapidsai:mainfrom
fallintoplace:fix-remote-range-overflow
Open

Check remote range end arithmetic#986
fallintoplace wants to merge 1 commit into
rapidsai:mainfrom
fallintoplace:fix-remote-range-overflow

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

Summary

  • reject remote range requests whose inclusive end offset would overflow
  • compute the CURLOPT_RANGE end offset only after the checked arithmetic passes
  • add a regression test that exercises the shared HTTP/S3 range setup helper without performing a transfer

Validation

  • pre-commit run --files cpp/src/remote_handle.cpp cpp/tests/test_remote_handle.cpp
  • git diff --check

Not run locally: ci/run_ctests.sh -R REMOTE_HANDLE_TEST because no installed/devcontainer KvikIO test build was present at the paths searched by the script.

@fallintoplace
fallintoplace requested a review from a team as a code owner June 23, 2026 19:45
@copy-pr-bot

copy-pr-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant