Fix install download script and statically link nvrtc (#452)

* don't use npx

* use CMake 3.26 (with a patch) so we can statically link libnvrtc

* organize workspace settings, ensure consistent vscode terminal cwd

* use npx again

* fix install_native_module if using npm 9 and npx is run by yarn 1

* switch back to using npx regular style

* make npm install work on node v19.6.0 and npm v9.4.1

* update cmake-js to use my fork with fixes

* don't need to include nvrtc_builtins_static

* set lower and upper bounds on CUDA major version (currently both 11)

* remove npm_config_nodedir testing override

* throw a helpful error message

* update copyright year

* remove @rapidsai/core postinstall cmake-js script

* fix devel packages local build with new cmake-js

* fix files list

* update lists of files that invalidate the images

Author: trxcllnt

.github/actions/build-and-publish-image-ssh/action.yml

@@ -114,7 +114,7 @@ runs:
       shell: bash
       run: |
         cp -ar "$HOME"/.{ssh,gitconfig} "$(realpath -m "${{ inputs.context }}")/dev/";
-        sed -i "s@$HOME@/root@g" "$(realpath -m "${{ inputs.context }}")/dev/.ssh/config";
+        sed -i "s@$HOME@/opt/rapids@g" "$(realpath -m "${{ inputs.context }}")/dev/.ssh/config";
     - name: Build image
       id: docker-build
       uses: docker/build-push-action@v2

.github/workflows/build-and-push-image-ssh.yml

@@ -112,11 +112,13 @@ jobs:
         with:
           base_sha: ${{ steps.last_main_commit.outputs.commit_hash }}
           files: |
+            .npmrc
+            yarn.lock
+            lerna.json
             ${{ inputs.file }}
             ${{ inputs.files-to-diff }}
-            lerna.json
             .github/workflows/merge.pr.yml
-            .github/workflows/build-and-push-image.yml
+            .github/workflows/build-and-push-image-ssh.yml
             .github/actions/build-and-publish-image-ssh/action.yml
 
       - name: Set environment variables

.github/workflows/build-and-push-image.yml

@@ -103,9 +103,11 @@ jobs:
         with:
           base_sha: ${{ steps.last_main_commit.outputs.commit_hash }}
           files: |
+            .npmrc
+            yarn.lock
+            lerna.json
             ${{ inputs.file }}
             ${{ inputs.files-to-diff }}
-            lerna.json
             .github/workflows/merge.pr.yml
             .github/workflows/build-and-push-image.yml
             .github/actions/build-and-publish-image/action.yml

.github/workflows/merge.pr.yml

@@ -21,9 +21,7 @@ jobs:
       file: dev/dockerfiles/devel/main.Dockerfile
       manual-build: ${{ github.event_name == 'workflow_dispatch' }}
       files-to-diff: |
-        .npmrc
         modules
-        yarn.lock
       build-args: |
         "UCX_VERSION=1.12.1"
 
@@ -39,9 +37,7 @@ jobs:
       file: dev/dockerfiles/devel/package.Dockerfile
       manual-build: ${{ github.event_name == 'workflow_dispatch' }}
       files-to-diff: |
-        .npmrc
         modules
-        yarn.lock
         dev/dockerfiles/devel/main.Dockerfile
       build-args: |
         "CUDAARCHS=ALL"
@@ -77,8 +73,8 @@ jobs:
       devel: devel-main
       file: dev/dockerfiles/runtime/cudf.Dockerfile
       files-to-diff: |
-        .npmrc
         modules/(core|rmm|cuda|cudf)
+        dev/dockerfiles/runtime/base.Dockerfile
       manual-build: ${{ github.event_name == 'workflow_dispatch' }}
 
   build-and-publish-runtime-cuml-image:
@@ -95,8 +91,8 @@ jobs:
       devel: devel-main
       file: dev/dockerfiles/runtime/cuml.Dockerfile
       files-to-diff: |
-        .npmrc
         modules/(core|rmm|cuda|cudf|cuml)
+        dev/dockerfiles/runtime/base.Dockerfile
       manual-build: ${{ github.event_name == 'workflow_dispatch' }}
 
   build-and-publish-runtime-cugraph-image:
@@ -113,8 +109,8 @@ jobs:
       devel: devel-main
       file: dev/dockerfiles/runtime/cugraph.Dockerfile
       files-to-diff: |
-        .npmrc
         modules/(core|rmm|cuda|cudf|cugraph)
+        dev/dockerfiles/runtime/base.Dockerfile
       manual-build: ${{ github.event_name == 'workflow_dispatch' }}
 
   build-and-publish-runtime-cuspatial-image:
@@ -131,8 +127,8 @@ jobs:
       devel: devel-main
       file: dev/dockerfiles/runtime/cuspatial.Dockerfile
       files-to-diff: |
-        .npmrc
         modules/(core|rmm|cuda|cudf|cuspatial)
+        dev/dockerfiles/runtime/base.Dockerfile
       manual-build: ${{ github.event_name == 'workflow_dispatch' }}
 
   build-and-publish-runtime-glfw-image:
@@ -149,8 +145,8 @@ jobs:
       devel: devel-main
       file: dev/dockerfiles/runtime/glfw.Dockerfile
       files-to-diff: |
-        .npmrc
         modules/(core|glfw|webgl)
+        dev/dockerfiles/runtime/base.Dockerfile
       manual-build: ${{ github.event_name == 'workflow_dispatch' }}
 
   build-and-publish-runtime-sql-image:
@@ -167,8 +163,8 @@ jobs:
       devel: devel-main
       file: dev/dockerfiles/runtime/sql.Dockerfile
       files-to-diff: |
-        .npmrc
         modules/(core|rmm|cuda|cudf|sql)
+        dev/dockerfiles/runtime/base.Dockerfile
       manual-build: ${{ github.event_name == 'workflow_dispatch' }}
       build-args: |
         "UCX_VERSION=1.12.1"
@@ -187,8 +183,8 @@ jobs:
       devel: devel-main
       file: dev/dockerfiles/runtime/main.Dockerfile
       files-to-diff: |
-        .npmrc
         modules/(core|cuda|glfw|webgl|rmm|cudf|sql|cuml|cugraph|cuspatial|deck.gl|jsdom)
+        dev/dockerfiles/runtime/base.Dockerfile
       manual-build: ${{ github.event_name == 'workflow_dispatch' }}
       build-args: |
         "UCX_VERSION=1.12.1"
@@ -207,8 +203,8 @@ jobs:
       devel: devel-main
       file: dev/dockerfiles/runtime/demo.Dockerfile
       files-to-diff: |
-        .npmrc
         modules/demo
+        dev/dockerfiles/runtime/base.Dockerfile
       manual-build: ${{ github.event_name == 'workflow_dispatch' }}
       build-args: |
         "UCX_VERSION=1.12.1"
@@ -224,7 +220,8 @@ jobs:
       image: runtime-notebook
       file: dev/dockerfiles/runtime/notebook.Dockerfile
       files-to-diff: |
-        .npmrc
         **/*.ipynb
         modules/demo
+        dev/dockerfiles/runtime/base.Dockerfile
+        dev/dockerfiles/runtime/demo.Dockerfile
       manual-build: ${{ github.event_name == 'workflow_dispatch' }}

dev/dockerfiles/devel/main.Dockerfile

@@ -37,7 +37,7 @@ ${CUDA_HOME}/nvvm/lib64:\
 ${CUDA_HOME}/lib64/stubs"
 
 ARG GCC_VERSION=9
-ARG CMAKE_VERSION=3.24.1
+ARG CMAKE_VERSION=3.26.0-rc1
 ARG SCCACHE_VERSION=0.2.15
 ARG LINUX_VERSION=ubuntu20.04
 
@@ -77,8 +77,6 @@ deb [signed-by=/usr/share/keyrings/kitware-archive-keyring.gpg] https://apt.kitw
     gfortran \
     ninja-build \
     gcc-${GCC_VERSION} g++-${GCC_VERSION} gdb \
-    cmake=${CMAKE_VERSION}-0kitware1${LINUX_VERSION}.1 \
-    cmake-data=${CMAKE_VERSION}-0kitware1${LINUX_VERSION}.1 \
     curl libssl-dev libcurl4-openssl-dev xz-utils zlib1g-dev liblz4-dev \
     # From opengl/glvnd:devel
     pkg-config \
@@ -89,6 +87,16 @@ deb [signed-by=/usr/share/keyrings/kitware-archive-keyring.gpg] https://apt.kitw
  && echo "/usr/local/nvidia/lib" >> /etc/ld.so.conf.d/nvidia.conf \
  && echo "/usr/local/nvidia/lib64" >> /etc/ld.so.conf.d/nvidia.conf \
  \
+ # Install cmake
+ && wget --no-hsts -q -O /tmp/cmake_${CMAKE_VERSION}.sh \
+    https://github.com/Kitware/CMake/releases/download/v${CMAKE_VERSION}/cmake-${CMAKE_VERSION}-linux-$(uname -p).sh \
+ && bash /tmp/cmake_${CMAKE_VERSION}.sh --skip-license --exclude-subdir --prefix=/usr \
+ # Fix FindCUDAToolkit.cmake finding the nvrtc_builtins_static library
+ # TODO: Remove this once https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8162 is released
+ && sed -i \
+    's/nvrtc_builtins_static DEPS cuda_driver/nvrtc_builtins_static ALT nvrtc-builtins_static DEPS cuda_driver/g' \
+    /usr/share/cmake-3.26/Modules/FindCUDAToolkit.cmake \
+ \
  # Install sccache
  && curl -SsL "https://github.com/mozilla/sccache/releases/download/v$SCCACHE_VERSION/sccache-v$SCCACHE_VERSION-$(uname -m)-unknown-linux-musl.tar.gz" \
     | tar -C /usr/bin -zf - --wildcards --strip-components=1 -x */sccache \
@@ -312,6 +320,7 @@ export PROMPT_COMMAND=\"history -a; \$PROMPT_COMMAND\";\n\
 
 ENV NO_UPDATE_NOTIFIER=1
 ENV RAPIDSAI_SKIP_DOWNLOAD=1
+ENV npm_config_nodedir=/usr/local
 ENV NODE_PATH=/usr/local/lib/node_modules
 ENV NODE_OPTIONS="--experimental-vm-modules --trace-uncaught"
 

dev/dockerfiles/devel/package.Dockerfile

@@ -31,20 +31,19 @@ COPY --chown=rapids:rapids yarn.lock     yarn.lock
 COPY --chown=rapids:rapids scripts       scripts
 COPY --chown=rapids:rapids modules       modules
 
-USER root
-
 ENV RAPIDSAI_SKIP_DOWNLOAD=1
 
-RUN --mount=type=ssh,required=true \
-    --mount=type=secret,id=sccache_credentials \
-    --mount=type=bind,source=dev/.ssh,target=/root/.ssh,rw \
-    --mount=type=bind,source=dev/.gitconfig,target=/etc/gitconfig \
+RUN --mount=type=ssh,uid=1000,gid=1000,required=true \
+    --mount=type=secret,id=sccache_credentials,uid=1000,gid=1000 \
+    --mount=type=bind,source=dev/.ssh,target=/opt/rapids/.ssh,rw \
+    --mount=type=bind,source=dev/.gitconfig,target=/opt/rapids/.gitconfig \
+    sudo chown -R $(id -u):$(id -g) /opt/rapids; \
     if [ -f /run/secrets/sccache_credentials ]; then \
         export $(grep -v '^#' /run/secrets/sccache_credentials | xargs -d '\n'); \
     fi; \
     # Add GitHub's public keys to known_hosts
-    if [ ! -f /root/.ssh/known_hosts ]; then \
-        curl -s https://api.github.com/meta | jq -r '.ssh_keys | map("github.com \(.)") | .[]' > /root/.ssh/known_hosts; \
+    if [ ! -f /opt/rapids/.ssh/known_hosts ]; then \
+        curl -s https://api.github.com/meta | jq -r '.ssh_keys | map("github.com \(.)") | .[]' > /opt/rapids/.ssh/known_hosts; \
     fi; \
     echo -e "build context:\n$(find .)" \
  && bash -c 'echo -e "\

modules/core/bin/cmake-js/linux.sh

@@ -0,0 +1,31 @@
+#!/usr/bin/env bash
+
+set -Eeo pipefail
+
+if ! type jq >/dev/null 2>&1; then
+    exit 0;
+fi
+
+cwd="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )";
+
+RAPIDS_MODULES_PATH="$(realpath "$cwd/../../../")";
+
+if [[ "$(basename "$RAPIDS_MODULES_PATH")" != modules ]]; then
+    exit 0;
+fi
+
+# Get the latest `compile_commands.json` from each module
+compile_command_files="$(                                   \
+find "$RAPIDS_MODULES_PATH" -mindepth 1 -maxdepth 1 -type d | xargs -n1 -I__ \
+    bash -c 'find __ -type f \
+        -path "*build/*/compile_commands.json" \
+        -exec stat -c "%y %n" {} + \
+  | sort -r \
+  | head -n1' \
+  | grep -Eo "$RAPIDS_MODULES_PATH/.*$" || echo "" \
+)";
+
+# Now merge them all together
+jq -s '.|flatten' $(echo "$compile_command_files")    \
+    > "$RAPIDS_MODULES_PATH/../compile_commands.json" \
+ || true;