Restore resource_cast guard for RAFT memory pool#3020
Merged
rapids-bot[bot] merged 1 commit intoMay 20, 2026
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
bdice
added
improvement
51 tasks
cjnolet
approved these changes
May 19, 2026
Member
|
/merge |
rapids-bot
Bot
merged commit 723d9bc
into
rapidsai:release/26.06
153 of 155 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #2996 migrated RAFT to the CCCL/RMM memory-resource model and temporarily removed the guard that prevented
device_resources_managerfrom overwriting a user-installed RMM resource. Now that CCCL providescuda::mr::resource_castsupport for RMM resources, restore that behavior usingrmm::mr::get_current_device_resource_ref().With this change,
device_resources_manageronly creates and installs its pool when the current resource is the defaultrmm::mr::cuda_memory_resource. If another resource is already installed, RAFT preserves it and emits the existing warning.The test coverage removed during #2996 is restored with
resource_castagainst the current resource ref.