Skip to content

Commit 9b3ec6b

Browse files
authored
wheels-build: do not fail fast (#517)
Proposes allowing all `wheels-build` jobs to run to completion, instead of immediately cancelling all of them when 1 fails. This should help with narrowing down issues, like "only fails on arm64". ## Motivation Noticed while working on rapidsai/cugraph#5479, where @ChuckHastings and I were investigating an issue that only occurred on CUDA 12 builds. Noticed that all `conda-cpp-build` jobs ran to completion, but `wheels-build` jobs were cancelled after the first failure. <img width="1837" height="733" alt="image" src="https://github.com/user-attachments/assets/70459440-e8b0-4a16-b955-b1a22452d11e" /> ## Notes for Reviewers This change will increase CI runner usage, but I think it's worth it: * CPU-only runners used for builds are generally cheap and plentiful * failed wheel build jobs are valuable: - they provide information to speed up debugging (e.g. "only fails on arm64") - they partially fill up the shared build caches and package caches, which other CI jobs benefit from and which might reduce the time-to-resolution for issues Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Bradley Dice (https://github.com/bdice) URL: #517
1 parent 4ede1f4 commit 9b3ec6b

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

.github/workflows/wheels-build.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@ jobs:
174174
name: ${{ matrix.CUDA_VER }}, ${{ matrix.PY_VER }}, ${{ matrix.ARCH }}, ${{ matrix.LINUX_VER }}
175175
needs: [compute-matrix]
176176
strategy:
177+
fail-fast: false
177178
matrix: ${{ fromJSON(needs.compute-matrix.outputs.MATRIX) }}
178179
runs-on: "linux-${{ matrix.ARCH }}-${{ inputs.node_type }}"
179180
env:

0 commit comments

Comments
 (0)