Adds fit_params support for ExhaustiveFeatureSelector#354
Merged
rasbt merged 6 commits intorasbt:masterfrom Mar 27, 2018
Merged
Adds fit_params support for ExhaustiveFeatureSelector#354rasbt merged 6 commits intorasbt:masterfrom
rasbt merged 6 commits intorasbt:masterfrom
Conversation
|
Hello @zdgriffith! Thanks for updating the PR.
Comment last updated on March 27, 2018 at 22:00 Hours UTC |
Contributor
Author
|
Sorry, I probably should have fit this into #350 . |
Owner
|
Thanks, Zach! And no worries, I think this way (having two PRs) makes it less confusing with regard to checking what's changed. The PR looks good to me, could you maybe also update the ExhaustiveFeatuerSelector.ipynb ? I.e., the last cell with the API documentation. You simply need to cd into mlxtend/docs, run |
Contributor
Author
|
Sorry about that, the notebook is updated now! |
Owner
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for fit parameters to be passed to the fit method of ExhaustiveFeatureSelector.
Related issues or pull requests
Related to Pull Requests #255 , #350
Pull Request requirements
./mlxtend/*/testsdirectoriesnosetests ./mlxtend -svand make sure that all unit tests passnosetests ./mlxtend --with-coverageflake8 ./mlxtend./docs/sources/CHANGELOG.mdfilemlxtend/docs/sources/(optional)