Skip to content

Commit bc96db7

Browse files
Yuuoniygregkh
authored andcommitted
drm/pl111: Fix error handling in pl111_amba_probe
commit 0ddd3bb4b14c9102c0267b3fd916c81fe5ab89c1 upstream. Jump to the existing dev_put label when devm_request_irq() fails so drm_dev_put() and of_reserved_mem_device_release() run instead of returning early and leaking resources. Found via static analysis and code review. Fixes: bed4100 ("drm/pl111: Initial drm/kms driver for pl111") Cc: stable@vger.kernel.org Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Signed-off-by: Linus Walleij <linusw@kernel.org> Link: https://patch.msgid.link/20251211123345.2392065-1-linmq006@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 90b4b13 commit bc96db7

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/pl111/pl111_drv.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ static int pl111_amba_probe(struct amba_device *amba_dev,
294294
variant->name, priv);
295295
if (ret != 0) {
296296
dev_err(dev, "%s failed irq %d\n", __func__, ret);
297-
return ret;
297+
goto dev_put;
298298
}
299299

300300
ret = pl111_modeset_init(drm);

0 commit comments

Comments
 (0)