drivers: media: pisp_be: Fix for job queue removal in stop_streaming()

The existing code unconditionally removes jobs from the job_queue list
when all the nodes in a node group have stopped streaming. This will
also remove jobs for any other node groups as the job_queue is a common
list. Fix this by only conditionally deleting jobs that belong to the
current node group.

Additionally, delete jobs as soon as the first node in the node group
stops streaming. Running a job with an incomplete set of active nodes
is invalid.

Fixes: 880153e ("media: pisp_be: Split jobs creation and scheduling")
Signed-off-by: Naushir Patuck <naush@raspberrypi.com>

Author: naushir

drivers/media/platform/raspberrypi/pisp_be/pisp_be.c

@@ -941,7 +941,6 @@ static void pispbe_node_stop_streaming(struct vb2_queue *q)
 	struct pispbe_dev *pispbe = node_group->pispbe;
 	struct pispbe_job_descriptor *job, *temp;
 	struct pispbe_buffer *buf;
-	LIST_HEAD(tmp_list);
 
 	/*
 	 * Now this is a bit awkward. In a simple M2M device we could just wait
@@ -968,20 +967,18 @@ static void pispbe_node_stop_streaming(struct vb2_queue *q)
 	spin_lock_irq(&pispbe->hw_lock);
 	node_group->streaming_map &= ~BIT(node->id);
 
-	if (node_group->streaming_map == 0) {
-		/*
-		 * If all nodes have stopped streaming release all jobs
-		 * without holding the lock.
-		 */
-		list_splice_init(&pispbe->job_queue, &tmp_list);
+	/*
+	 * If a node has stopped streaming release all jobs belonging to the
+	 * node group immediately.
+	 */
+	list_for_each_entry_safe(job, temp, &pispbe->job_queue, queue) {
+		if (job->node_group == node->node_group) {
+			list_del(&job->queue);
+			kfree(job);
+		}
 	}
 	spin_unlock_irq(&pispbe->hw_lock);
 
-	list_for_each_entry_safe(job, temp, &tmp_list, queue) {
-		list_del(&job->queue);
-		kfree(job);
-	}
-
 	pm_runtime_mark_last_busy(pispbe->dev);
 	pm_runtime_put_autosuspend(pispbe->dev);