Revert "usb: dwc2: masquerade split-interrupt transfers"

This reverts commit 781f2e0.

dwc2 is sufficiently different to dwc_otg that the same override can't be
cleanly applied - it ends up spamming the endpoint with start-splits and
rarely schedules complete-splits.

Signed-off-by: Jonathan Bell <jonathan@raspberrypi.com>

Author: P33M

drivers/usb/dwc2/hcd.c

@@ -676,19 +676,7 @@ static void dwc2_hc_init(struct dwc2_hsotg *hsotg, struct dwc2_host_chan *chan)
 		hcchar |= HCCHAR_EPDIR;
 	if (chan->speed == USB_SPEED_LOW)
 		hcchar |= HCCHAR_LSPDDEV;
-
-	/*
-	 * Masquerading Interrupt split transfers as Control puts the transfer
-	 * into the non-periodic handler in the hub. This stops the hub
-	 * dropping complete-split data in the microframe after a CSPLIT
-	 * should have arrived, improving resilience to host IRQ latency.
-	 * Devices are none the wiser - the handshake tokens are the same.
-	 */
-	if (chan->do_split && chan->ep_type == USB_ENDPOINT_XFER_INT)
-		hcchar |= USB_ENDPOINT_XFER_CONTROL << HCCHAR_EPTYPE_SHIFT & HCCHAR_EPTYPE_MASK;
-	else
-		hcchar |= chan->ep_type << HCCHAR_EPTYPE_SHIFT & HCCHAR_EPTYPE_MASK;
-
+	hcchar |= chan->ep_type << HCCHAR_EPTYPE_SHIFT & HCCHAR_EPTYPE_MASK;
 	hcchar |= chan->max_packet << HCCHAR_MPS_SHIFT & HCCHAR_MPS_MASK;
 	dwc2_writel(hsotg, hcchar, HCCHAR(hc_num));
 	if (dbg_hc(chan)) {