Skip to content

Commit 53dc136

Browse files
committed
ARM: dts: bcm2710: replace lan78xx downstream EEE properties with eee-broken
Remove the downstream microchip,eee-enabled and microchip,tx-lpi-timer properties from the Pi 3B+ PHY node. These were consumed by the downstream lan78xx driver patches which have been reverted now that upstream (since v6.17) integrates EEE via the phylink LPI API with eee_enabled_default=true and lpi_timer_default=50. Replace the eee dtparam with standard eee-broken-1000t/eee-broken-100tx properties. Setting dtparam=eee=off adds the eee-broken properties to prevent EEE negotiation. EEE is enabled by default. Drop the tx_lpi_timer dtparam as the LPI timer is now managed by phylink and configurable via ethtool --set-eee. Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>
1 parent 37bfe46 commit 53dc136

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

arch/arm/boot/dts/broadcom/bcm2710-rpi-3-b-plus.dts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -258,8 +258,6 @@
258258
};
259259

260260
&eth_phy {
261-
microchip,eee-enabled;
262-
microchip,tx-lpi-timer = <600>; /* non-aggressive*/
263261
microchip,downshift-after = <2>;
264262
};
265263

@@ -285,8 +283,8 @@ i2c_csi_dsi0: &i2c0 {
285283
pwr_led_activelow = <&led_pwr>,"gpios:8";
286284
pwr_led_trigger = <&led_pwr>,"linux,default-trigger";
287285

288-
eee = <&eth_phy>,"microchip,eee-enabled?";
289-
tx_lpi_timer = <&eth_phy>,"microchip,tx-lpi-timer:0";
286+
eee = <&eth_phy>,"eee-broken-1000t!",
287+
<&eth_phy>,"eee-broken-100tx!";
290288
eth_led0 = <&eth_phy>,"microchip,led-modes:0";
291289
eth_led1 = <&eth_phy>,"microchip,led-modes:4";
292290
eth_downshift_after = <&eth_phy>,"microchip,downshift-after:0";

arch/arm/boot/dts/overlays/README

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -233,8 +233,8 @@ Params:
233233
drm_fb2_vc4 Assign /dev/fb2 to the vc4 outputs
234234

235235
eee Enable Energy Efficient Ethernet support for
236-
compatible devices (default "on"). See also
237-
"tx_lpi_timer". Pi3B+, Pi4, CM4, Pi5 and CM5.
236+
compatible devices (default "on").
237+
Pi3B+, Pi4, CM4, Pi5 and CM5.
238238

239239
enable_eeprom Set to "on" to enable the onboard bootloader
240240
EEPROM by driving GPIO 57 low
@@ -455,10 +455,6 @@ Params:
455455
suspend Make the power button trigger a suspend rather
456456
than a power-off (2712 only, default "off")
457457

458-
tx_lpi_timer Set the delay in microseconds between going idle
459-
and entering the low power state (default 600).
460-
Requires EEE to be enabled - see "eee".
461-
462458
uart0 Set to "off" to disable uart0 (default "on")
463459

464460
uart0_console Move the kernel boot console to UART0 on pins

0 commit comments

Comments
 (0)